Conversation
added 4 commits
September 26, 2024 17:05
This function returns a response that calls render_block_to_string() under the hood to generate the content of the response. (cherry picked from commit 4d9297e)
(cherry picked from commit e46abe5)
Because render_block() must be called from view code, the settings have been changed for the tests to include a "tests" app, with a single URL and a single View class. (cherry picked from commit 1e1683a)
This is more in sync with the rest of the project and is a bit easier to understand. (cherry picked from commit 97819c4)
Contributor
Author
|
This is my first pull request ever, so I might need some help with Github. It seems I created a new issue, but this pull request is intended to fix #59. |
Contributor
Author
|
I figured out how to run the build steps locally on my computer, so I could fix the linter errors. My branch now locally passes the CI steps. |
|
@clokep any change this gets merged? |
Owner
|
Sorry for the delay. I pushed a bunch of changes which heavily simplifies the code. If we want something similar to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the
render_block()function that returns anHttpResponsewith the block.It also allows to verify the context that was passed to
render_block()in unit tests.Closes #59