Conversation
…y checked Signed-off-by: Hugues Clouâtre <hugues@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenSSF badge script skips the entire criterion entry (including justification textarea) when the radio button is already checked. This means updated justification strings (e.g., MIT -> Apache 2.0) never reach the OpenSSF database on re-runs.
Root cause
In
fillSection(), the justificationtextarea.fill()block sits inside theelsebranch of theisChecked || isDisabledcheck. It should be outside theif/elseentirely.Fix
Move the justification update block (lines ~1013-1022) to execute unconditionally after the radio check, whether or not the radio was skipped.
Changes
scripts/fill-openssf-badge.ts-- restructurefillSection()so textarea fill always runsTest plan