Conversation
Output Example [Outdated see the next one] |
b9e2c73 to
1e0422d
Compare
Output example including change points summary |
|
/hold |
|
I think we need to consider if we really need this? If somebody wants to look at the whole data there are multiple ways/output formats to export. Adding this as an extra flag isn't adding much value. On the other hand, if looking at condensed output which only shows the changepoints is a goal, this needs collaboration with @mohit-sheth on their PR to consider collapse as an option which shares the similar thought process and isn't being used much anywhere at the moment. |
|
Hi @vishnuchalla I think it is it has been a constant complain that is impossible to correctly see and understand the table. This allows the table to be seen and understood, and provide a summary, reusing the data we already have. |
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
447d931 to
27a528b
Compare
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
afcollins
left a comment
There was a problem hiding this comment.
I think the collapsed output and configurable columns looks great.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afcollins The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Type of change
Description
Adds the option to configure the number of metrics per column group in the plain-text report. When many metrics are present, the report splits them into multiple tables; each table shows the same time and attribute columns plus a subset of metrics.
--collapseoption to orion text mode, it will only print the summary.-jsonandxmldo not print output to stdout anymoreRelated Tickets & Documents
Checklist before requesting a review
Testing