WIP - Iterate over percents array for percentile aggregations#326
Open
afcollins wants to merge 1 commit intocloud-bulldozer:mainfrom
Open
WIP - Iterate over percents array for percentile aggregations#326afcollins wants to merge 1 commit intocloud-bulldozer:mainfrom
afcollins wants to merge 1 commit intocloud-bulldozer:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
cc: @chentex Since you wrote the initial code and probably understand the intention behind target_percentile, I just wanted something working today, so I put this together quickly. |
afcollins
force-pushed
the
percents_325
branch
2 times, most recently
from
6181416 to
64b34fd
Compare
Removes the notion of 'default' target_percentile, which effectively negates querying a range of percentiles. Fixes cloud-bulldozer#325 Aided by Cursor using claude-4.6-sonnet model. Signed-off-by: Andrew Collins <ancollin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the notion of 'default' target_percentile, which effectively negates querying a range of percentiles.
Fixes #325
Aided by Cursor using claude-4.6-sonnet model.
Type of change
Description
When a list of 'percents' is configured on a percentile aggregation, iterate over this list to build out queries, keys, and columns for presentation and change point detection.
Key/column format will be like:
podReadyLatency_percentiles_10.0Added an example to show how to use with kube-burner's metrics profile and podLatency measurements (i.e. not podLatencyMeasurementQuantiles)
Related Tickets & Documents
Checklist before requesting a review
Testing