Skip to content

labels.container.keyword filters to CPU metrics#338

Open
mukrishn wants to merge 4 commits intocloud-bulldozer:mainfrom
mukrishn:add-container-filter
Open

labels.container.keyword filters to CPU metrics#338
mukrishn wants to merge 4 commits intocloud-bulldozer:mainfrom
mukrishn:add-container-filter

Conversation

@mukrishn
Copy link
Copy Markdown

@mukrishn mukrishn commented Apr 2, 2026

Add labels.container.keyword filters to CPU metrics in trt-external-payload configs to query specific containers instead of aggregating across all containers in a namespace

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign josecastillolema for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mukrishn mukrishn requested a review from mohit-sheth April 2, 2026 22:17
@afcollins
Copy link
Copy Markdown
Member

Needs rebase to pass test.

Also, please can we attach orion output using these configs so we can see what changepoints may change upon merge? Maybe we can proactively add ack's to this PR as well so they can all go in together.

mukrishn added 3 commits April 8, 2026 12:56
Signed-off-by: Murali Krishnasamy <mukrishn@redhat.com>
Signed-off-by: Murali Krishnasamy <mukrishn@redhat.com>
Signed-off-by: Murali Krishnasamy <mukrishn@redhat.com>
@mukrishn mukrishn force-pushed the add-container-filter branch from 8068582 to f630d2a Compare April 8, 2026 17:03
Signed-off-by: Murali Krishnasamy <mukrishn@redhat.com>
@mohit-sheth
Copy link
Copy Markdown
Collaborator

/lgtm

@mukrishn
Copy link
Copy Markdown
Author

mukrishn commented Apr 8, 2026

Needs rebase to pass test.

Also, please can we attach orion output using these configs so we can see what changepoints may change upon merge? Maybe we can proactively add ack's to this PR as well so they can all go in together.

tested out - https://gist.github.com/mukrishn/46cd17cf3e0e94984c715bcdade787be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants