Unit tests for more coverage#340
Draft
afcollins wants to merge 11 commits intocloud-bulldozer:mainfrom
Draft
Conversation
Covers 109 new tests across utils (62) and config (47), bringing total to 153. Includes behavior-guard tests for float timestamp handling and YAML numeric coercion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…and CMR 41 new tests covering output formatting (json/text/junit), analysis caching, series setup, direction/threshold/ack filtering, changepoint grouping, anomaly detection, mean comparison, and the algorithm factory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
60 new tests covering timestamp coercion (13 input types), ISO parsing, interval validation, request error handling (404/403/500/timeout/bad JSON), URL building, release/commit processing, caching, change context assembly, and PR creation date lookup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
29 new tests for run_test.py: get_algorithm_type, has_early_changepoint, clear_early_changepoints, get_start_timestamp (incl. PR creation date), tabulate_average_values, and NamedTuple structures. 20 new tests for matcher.py gaps: get_metadata_by_uuid actual logic, get_uuid_by_metadata edge cases (buildUrl fallback, additional_fields, dotted version field, not clause, ocpMajorVersion, pullNumber=0), parse_agg_results without aggregations, convert_to_df/save_results column filtering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…runs, agg types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers _short_version, _prepare_timestamps, _classify_changepoint, VizData, _build_test_figure, and generate_test_html. Includes behavior guard documenting that direction=1 means increase-is-regression, which is opposite to the EDivisive convention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers ReportType enum, produce_report dispatching, LOG/JSON/regressions_only formats, changepoint annotations, column_group_size, and helper methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move pylint invocation from workflow inline command to Makefile lint target. Exclude test files from lint (grep -v '/tests/') and document remaining lint cleanup in TODO_unittest.txt. Partial lint fixes applied: unused imports removed, unused variables prefixed, _make_algo renamed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Andrew Collins <ancollin@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Andrew Collins <ancollin@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Andrew Collins <ancollin@redhat.com>
afcollins
changed the title
Member
|
thanks for opening this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Generated unit tests for 100% coverage to provide a foundation before any refactoring.
Related Tickets & Documents
Checklist before requesting a review
Testing