Refactor and formatting improvements #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsevilla87
force-pushed
the
formatting
branch
2 times, most recently
from
b571de9 to
b13a10d
Compare
rsevilla87
force-pushed
the
formatting
branch
3 times, most recently
from
a2037b9 to
3f4e18c
Compare
|
I think just needs a few conflicts to be resolved. |
jtaleric
reviewed
May 30, 2025
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
formatting
branch
2 times, most recently
from
2fb7748 to
3cb5f73
Compare
Signed-off-by: Raul Sevilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Let's stop passing the index as argument in every method.
There're breaking changes changes throughout this PR that will require Orion to be updated.⚠️ ⚠️
Related Tickets & Documents
Checklist before requesting a review
Testing