Add imagePullSecrets to the LavinMQ spec - #82
Open
erkki wants to merge 4 commits into
Open
Conversation
Passes spec.imagePullSecrets through to the StatefulSet pod template so the LavinMQ image can be pulled from private registries.
There was a problem hiding this comment.
Pull request overview
Adds support for pulling the LavinMQ container image from private registries by exposing spec.imagePullSecrets on the LavinMQ CRD and attempting to propagate it into the StatefulSet pod template.
Changes:
- Add
spec.imagePullSecretsto the LavinMQ API type. - Update generated deepcopy code to include the new field.
- Extend the CRD OpenAPI schema with the new
imagePullSecretsfield. - Propagate
spec.imagePullSecretsinto the StatefulSet pod template (create path).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/reconciler/statefulset.go | Attempts to wire spec.imagePullSecrets into the StatefulSet pod template. |
| config/crd/bases/cloudamqp.com_lavinmqs.yaml | Adds CRD schema for spec.imagePullSecrets. |
| api/v1alpha1/zz_generated.deepcopy.go | Regenerates deepcopy logic for the new field. |
| api/v1alpha1/lavinmq_types.go | Adds ImagePullSecrets to the LavinMQSpec API type. |
Files not reviewed (1)
- api/v1alpha1/zz_generated.deepcopy.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Setting imagePullSecrets in appendSpec only affected newly created StatefulSets; diffTemplate never synced the field, so changing or removing spec.imagePullSecrets left existing StatefulSets untouched. Diff it like the other pod template fields and cover the full lifecycle (create, change, remove) with a test.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes spec.imagePullSecrets through to the StatefulSet pod template so the LavinMQ image can be pulled from private registries.