proof of concept for message durability #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromepochat
changed the title
jeromepochat
changed the title
Comment on lines
-93
to
-97
| /** Flush events in the message queue. */ | ||
| public void flush() { | ||
| client.flush(); | ||
| } | ||
|
|
There was a problem hiding this comment.
question: Looks to be a breaking change. Could we implement the flush method based on the new architecture? or at least depreciate it with empty or minimal implementation (warning log)?
There was a problem hiding this comment.
this method is misleading. Flushing does not guarantee that messages will be delivered.
IMHO the API for segment should be a simple, "hey, there is the message, do your best"
There was a problem hiding this comment.
I understand your point. I'm just thinking about binary compatibility, the upgrade should ideally not require any changes from users.
|
#2 another approach using small size files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.