-
Notifications
You must be signed in to change notification settings - Fork 10
Update database name from Cloudberry Database to Apache Cloudberry #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since Cloudberry was donated to Apache, the database name in version() was renamed from Cloudberry Database to Apache Cloudberry. Some tools or extensions rely on the name to recognize database. This commit renames the database name to adapt the change from Apache Cloudberry.
my-ship-it
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I have concerns about this PR's changes from "Cloudberry Database" to "Apache Cloudberry". While I understand the motivation to align with the new Apache branding, this change would break compatibility with existing Cloudberry Database installations in production environments. Issues identified:
Suggestion:
This approach would:
Please consider revising the PR to implement this more backward-compatible approach. Let me know if you would like specific guidance on implementing these changes. #13 |
The old pattern is still kept. The commit adds new pattern for |
| if ver, ok := dbversion.extractVersion(cbdbPattern); ok { | ||
| dbversion.Type = CBDB | ||
| dbversion.SemVer = ver | ||
| } else if ver, ok := dbversion.extractVersion(cbdbNewPattern); ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle both Apache Cloudberry and Cloudberry Database by classifying them as CBDB, this approach could lead to issues in the future:
-
Version number conflicts: For example, in [Bug] Error in copy some tables #13 we see Apache Cloudberry 1.6.0, but Cloudberry Database 1.6.0 also exists. These are different database products with the same version number.
-
Catalog differences: Apache Cloudberry and Cloudberry Database likely have different catalogs. By treating them as the same type (CBDB), how can we correctly handle their metadata differences when generating DDL statements?
Are you sure that Apache Cloudberry and Cloudberry Database have exactly the same catalog? If not, we need to identify the differences to ensure our metadata queries work correctly for both databases and can generate appropriate DDL statements for each.
We should identify them as different database types and handle version checks differently in all places where we query metadata and generate DDL statements.
Since Cloudberry was donated to Apache, the database name in version() was renamed from Cloudberry Database to Apache Cloudberry. Some tools or extensions rely on the name to recognize database. This commit renames the database name to adapt the change from Apache Cloudberry.
fix #ISSUE_Number
Change logs
Contributor's checklist
Here are some reminders before you submit your pull request: