[ui-importer] Add (Composite) Primary key column in bulk column modal #4281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
ananya-agarwal
requested review from
JohanAhlen,
bjornalm,
ramprasadagarwal and
tabraiz12
and removed request for
bjornalm
UI Code Coverage Report
|
Backend Code Coverage Report •
|
...op/core/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumnsModal/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
JohanAhlen
reviewed
Oct 27, 2025
...re/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumnsModal/EditColumnsModal.test.tsx
Show resolved
Hide resolved
ananya-agarwal
changed the title
tabraiz12
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Primary key column in bulk column modal.
How was this patch tested?
Manual testing. Updated unit tests.
Video for the initial phase - introducing the Primary Key.
Screen.Recording.2025-10-27.at.3.51.14.PM.mov
Video for Composite Primary Key.
Screen.Recording.2025-11-11.at.2.07.38.PM.mov
Please review Hue Contributing Guide before opening a pull request.