-
Notifications
You must be signed in to change notification settings - Fork 404
[ui-adminServer-improvements] Improving the nits for the Administrator Server Pages - Metrics and Quick start page #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3051827
Nits in the admin pages
ananya-agarwal 7e3683e
using key directly as a parameter
ananya-agarwal 0282170
Merge remote-tracking branch 'upstream' into nitsAdmin
ananya-agarwal efe3471
Getting internationalization in
ananya-agarwal a5ee290
nits after review
ananya-agarwal fc92ab0
renaming the object
ananya-agarwal 8e131f0
use the keys here directly and drop the label mapping file completely
ananya-agarwal e135419
Fixing the related tests
ananya-agarwal ae121d8
tableData.caption is unique thus using that as a key instead of index
ananya-agarwal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
desktop/core/src/desktop/js/apps/admin/Metrics/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Licensed to Cloudera, Inc. under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. Cloudera, Inc. licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // 'License'); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an 'AS IS' BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| export const metricLabels: { [key: string]: string } = { | ||
ananya-agarwal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 'queries.number': 'Number of Queries', | ||
| 'requests.active': 'Active Requests', | ||
| 'requests.exceptions': 'Request Exceptions', | ||
| 'requests.response-time': 'Request Response Time', | ||
| 'threads.daemon': 'Daemon Threads', | ||
| 'threads.total': 'Total Threads', | ||
| users: 'Users', | ||
| 'users.active': 'Active Users', | ||
| 'users.active.total': 'Total Active Users' | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.