[ui-adminPages-config] Fix the configuration page with loading wrapper hook #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
UI Code Coverage Report
|
Removing the unneccsary comments from the test file
ananya-agarwal
force-pushed
the
LoadingConfig
branch
from
0c578fa to
3cf2a83
Compare
Backend Code Coverage Report •
|
ananya-agarwal
requested review from
JohanAhlen,
bjornalm,
ramprasadagarwal and
tabraiz12
ramprasadagarwal
requested changes
Oct 27, 2025
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.test.tsx
Show resolved
Hide resolved
JohanAhlen
reviewed
Oct 27, 2025
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.tsx
Outdated
Show resolved
Hide resolved
bjornalm
approved these changes
Oct 28, 2025
Collaborator
bjornalm
left a comment
bjornalm
left a comment
There was a problem hiding this comment.
Looks good once you addressed all the feedback
desktop/core/src/desktop/js/apps/admin/Configuration/ConfigurationTab.test.tsx
Outdated
Show resolved
Hide resolved
ramprasadagarwal
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updating the Configuration pages in the Administrator pages with Loading wrapper hook for better readability and clean code.
How was this patch tested?
Unit tests updated. No change in the overall behavior or functioning of the code.