Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions desktop/core/base_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ cffi==1.15.0
channels==4.2.2
channels-redis==4.2.1
configobj==5.0.9
cx-Oracle==8.3.0
oracledb==2.0.0
django-auth-ldap==4.3.0
Django==4.2.23
Django==4.2.24
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daphne==3.0.2
django-redis==5.4.0
django-celery-beat==2.6.0
Expand Down
4 changes: 0 additions & 4 deletions desktop/core/build-constraints.txt

This file was deleted.

4 changes: 2 additions & 2 deletions desktop/core/generate_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ def __init__(self):
"channels==4.2.2",
"channels-redis==4.2.1",
"configobj==5.0.9",
"cx-Oracle==8.3.0",
"oracledb==2.0.0",
"daphne==3.0.2",
"Django==4.2.23",
"Django==4.2.24",
"django-auth-ldap==4.3.0",
"django-celery-beat==2.6.0",
"django-celery-results==2.5.1",
Expand Down
2 changes: 1 addition & 1 deletion desktop/core/src/desktop/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from builtins import range
from datetime import datetime, timedelta

from cx_Oracle import DatabaseError as OracleDatabaseError
from oracledb import DatabaseError as OracleDatabaseError
from django.db import connection
from django.db.utils import DatabaseError, OperationalError
from future import standard_library
Expand Down
8 changes: 4 additions & 4 deletions desktop/core/src/desktop/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -794,22 +794,22 @@ def test_check_config_ajax():
assert "misconfiguration" in response.content, response.content


def test_cx_Oracle():
def test_oracledb():
"""
Tests that cx_Oracle (external dependency) is built correctly.
Tests that oracledb (external dependency) is built correctly.
"""
if 'ORACLE_HOME' not in os.environ and 'ORACLE_INSTANTCLIENT_HOME' not in os.environ:
pytest.skip("Skipping Test")

try:
import cx_Oracle
import oracledb

return
except ImportError as ex:
if "No module named" in ex.message:
assert (
False,
"cx_Oracle skipped its build. This happens if "
"oracledb skipped its build. This happens if "
"env var ORACLE_HOME or ORACLE_INSTANTCLIENT_HOME is not defined. "
"So ignore this test failure if your build does not need to work "
"with an oracle backend.",
Expand Down
4 changes: 2 additions & 2 deletions desktop/libs/librdbms/src/librdbms/server/oracle_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
import logging

try:
import cx_Oracle as Database
import oracledb as Database
except ImportError as e:
from django.core.exceptions import ImproperlyConfigured
raise ImproperlyConfigured("Error loading cx_Oracle module: %s" % e)
raise ImproperlyConfigured("Error loading oracledb module: %s" % e)

from librdbms.server.rdbms_base_lib import BaseRDBMSDataTable, BaseRDBMSResult, BaseRDMSClient

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ Currently, only [basic LDAP authentication](https://github.com/trinodb/trino-pyt

The dialect should be added to the Python system or Hue Python virtual environment:

./build/env/bin/pip install cx_Oracle
./build/env/bin/pip install oracledb

Then give Hue the information about the database source:

Expand Down