Skip to content

Conversation

@daszabo
Copy link
Contributor

@daszabo daszabo commented Oct 24, 2024

  • Added cascading delete option to environments
  • environment and data lake delete should now always poll

@daszabo daszabo requested a review from a team as a code owner October 24, 2024 14:55
@daszabo daszabo requested a review from gregito October 24, 2024 14:57
gregito
gregito previously approved these changes Oct 25, 2024
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though it is strange that the test(s) break only on windows

@github-actions
Copy link

Go test coverage: 33.0% for commit 1a38a24
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                            | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                   |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                     |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub            |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake           |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                 |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw                 |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws     |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments       |    44.3%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                 |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb               |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                        |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                   |    68.8%

@daszabo daszabo requested a review from gregito October 29, 2024 13:45
@gregito gregito enabled auto-merge (rebase) October 29, 2024 13:48
@gregito gregito merged commit f55d4f3 into main Oct 29, 2024
9 checks passed
@gregito gregito deleted the CB-27556 branch October 29, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants