DWX-20183 Deprecate standalone default database catalog resource #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default database catalog is now managed as part of the cluster since its lifecycle is inherently tied to the cluster's lifecycle. All properties are now computed. New data warehouse cluster setups should use the embedded catalog properties instead. - deprecate the database catalog resource - add default database catalog properties under dw aws cluster resource - Add test fixes and acceptance test changes Instance type properties are also computed. These values were not populated from the API before. There are default instance types that we should store in the state. The additional instance type attribute was not used, this property got dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default database catalog is now managed as part of the cluster since its lifecycle is inherently tied to the cluster's lifecycle. All properties are now computed. New data warehouse cluster setups should use the embedded catalog properties instead.
Instance type properties are also computed. These values were not populated from the API before. There are default instance types that we should store in the state. The additional instance type attribute was not used, this property got dropped.