Skip to content

feat: add support for conditional creation and association of network security groups - #100

Merged
lixhunter merged 2 commits into
mainfrom
feat/add-conditional-security-group
Jun 10, 2026
Merged

feat: add support for conditional creation and association of network security groups#100
lixhunter merged 2 commits into
mainfrom
feat/add-conditional-security-group

Conversation

@lixhunter

@lixhunter lixhunter commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added documentation written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have checked for a proper tag for this PR: breaking-change, feature, fix, other, ignore-release
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.

Motivation and Context

Feedback from @matthiasbretag:

But we have a new issue. For some reason, network security groups are created now for each NIC which is not a behavior we want or require. Would you please check and make another change so this gets fixed. I believe this behavior might have been introduced with one of the prior versions, probably v1.8.0.

With the adjustments below one should set the following parameter;

create_network_security_group  = false

and this should prevent the creation of NSGs.

Breaking Changes

… security groups

Signed-off-by: Andre Licht <al@cloudeteer.de>
@lixhunter
lixhunter requested review from a team and Phil-Thoennissen as code owners June 10, 2026 09:59
@lixhunter
lixhunter requested a review from cjedro June 10, 2026 09:59
@lixhunter lixhunter self-assigned this Jun 10, 2026
@lixhunter
lixhunter enabled auto-merge (squash) June 10, 2026 10:06
Comment thread variables.tf Outdated
@lixhunter
lixhunter disabled auto-merge June 10, 2026 11:13
Signed-off-by: Andre Licht <al@cloudeteer.de>
@lixhunter
lixhunter requested a review from HelenaSeidel June 10, 2026 12:36
@lixhunter
lixhunter enabled auto-merge (squash) June 10, 2026 12:37

@HelenaSeidel HelenaSeidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo ok

@lixhunter
lixhunter merged commit e54da63 into main Jun 10, 2026
10 checks passed
@lixhunter
lixhunter deleted the feat/add-conditional-security-group branch June 10, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants