Allow tags for each data_disk - #90
Merged
Merged
Conversation
Signed-off-by: Roman Schwarz <rs@cloudeteer.de>
rswrz
requested review from
Phil-Thoennissen,
lixhunter and
neonwhiskers
as code owners
February 25, 2026 12:52
rswrz
enabled auto-merge (squash)
February 25, 2026 12:52
rswrz
disabled auto-merge
February 25, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for per–data disk tagging by extending the
data_disksschema with an optionaltagsmap and merging those tags with the module-levelvar.tagswhen creatingazurerm_managed_diskresources.What Changed
data_disksobject type to include an optionaltagsmap (default{}).README.mdandvariables.tf.Why
Consumers may require disk-specific metadata (e.g., cost center, classification, backup policy) while maintaining a consistent baseline tag set across the module. This change enables flexible tagging without duplicating resources or modifying module structure.
Impact
data_disks[*].tags.var.tagson key conflicts.var.tagsis ever set tonull,merge()would fail (assumingvar.tagsis expected to be a map).