Chain validation cleanup #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the inferred root is not yet appended, but we'll do that next.
Rename intermediates to chain_certs as well, to help highlight where the chain is used.
…trap entry Ensure found roots are properly accounted for, mirroring a change to the static CT worker. Also rename validation_hook to validator_hook for consistency, and improve function documentation.
Also rename is_pre_issuer to is_precert_signing_cert for clarity.
rozbb
approved these changes
Sep 26, 2025
|
|
||
| hook(leaf, chain_certs_owned, chain_fingerprints, found_root_idx) | ||
| .map_err(HookOrValidationError::Hook) | ||
| hook(leaf, chain_certs, chain_fingerprints, found_root_idx).map_err(HookOrValidationError::Hook) |
Contributor
There was a problem hiding this comment.
Good job managing to rewrite the hooks to work with Vec<&Certificate>. I think getting the full chain including root is much cleaner
Contributor
Author
There was a problem hiding this comment.
Yeah! After moving the well-formedness check to validate_chain_lax I didn't get many complaints about ownership.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanup and documentation improvements, mostly related to chain validation and addressing review comments from #113. Please see individual commit messages for details.