mtc_worker: Return MTC validity window on add entry #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
commented
Oct 8, 2025
lukevalenta
reviewed
Oct 8, 2025
lukevalenta
reviewed
Oct 8, 2025
cjpatton
force-pushed
the
cjpatton/add-entry-validity-window
branch
from
cf38de6 to
dad27c0
Compare
lukevalenta
reviewed
Oct 8, 2025
lukevalenta
approved these changes
Oct 8, 2025
Contributor
lukevalenta
left a comment
lukevalenta
left a comment
There was a problem hiding this comment.
Just one comment left to update, but otherwise looks good!
Add the MTC validity window to `AddEntryResponse`. In case the entry was cached, it would be necessary to parse the validity window from the entry itself. However, for now we don't actually want to cache MTC entries, so remove caching for now.
cjpatton
force-pushed
the
cjpatton/add-entry-validity-window
branch
from
dad27c0 to
0d297b5
Compare
lukevalenta
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the MTC validity window to
AddEntryResponse. In case the entry was cached, it would be necessary to parse the validity window from the entry itself. However, for now we don't actually want to cache MTC entries, so remove caching for now.