Various changes to landmark bundle #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkpoint is already printer friendly, so no need to base64 encode it.
cjpatton
force-pushed
the
cjpatton/validate-landmark-bundle
branch
6 times, most recently
from
3cd7abb to
1b2b397
Compare
cjpatton
force-pushed
the
cjpatton/validate-landmark-bundle
branch
from
1b2b397 to
17ea329
Compare
bwesterb
approved these changes
Oct 29, 2025
The label needs a newline after "mtc-subtree/v1". This is a breaking changes, since previous checkpoints can no longer be opened. This is a breaking change: Because the signatures won't verify, mtc_worker won't be able to open older check points.
This type is currently a struct that thinly wraps `RelativeOid`. In fact, this is the only attribute of the struct, and it's `pub`. This suggests that what we really want is a type alias.
For the purposes of computing the tlog key ID, the log ID is used as the key name. Add a method for encoding the arcs as a string so that we can properly construct the key name. Implementation note: Currently we only keep around the DER encoding of the arcs. We could decode the arcs from the DER blob, but it's a bit more convenient to just keep the arcs around in the data structure.
MTC changes the way the key name and ID are computed compared to TLOG. First, the key name is constructed from the log ID rather than the API endpoint. Second, the key ID does not incorporate the public key as it does in TLOG. This is a breaking change: Because the signatures won't verify, mtc_worker won't be able to open older check points.
MTC cosigners sign two types of notes: one for checkpoints and another for subtrees. Apart from the notes having a slightly different format, we need to construct a separate key ID for each case. To accommodate this, we need to be able to construct an instance of the cosigenr based on the type of note we're signing. Replace `MTCSubtreeCosigner` with a more general `MtcCosigner` struct. The idea is that the constructor will define which type of message is being signed (a checkpoint or a subtree) and construct the key ID accordingly. At the moment, we don't actually use the MTC cosigner to sign subtrees; for now, we just use it to sign checkpoints. Replace the current constructor `new()` with one that that constructs a checkpoint signer, `new_checkpoint()`. Likewise for the note verifier. This is a breaking change: Because the signatures won't verify, mtc_worker won't be able to open older check points.
Instead of base64 encoding the BER, just return the string encoding.
cjpatton
force-pushed
the
cjpatton/validate-landmark-bundle
branch
from
17ea329 to
9a363ca
Compare
Contributor
Author
|
Updated commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
I suggest reviewing commit-by-commit.
Note: This is a breaking change in the sense that we won't be able to open older checkpoints. We'll need to spin up another shard.