mtc_worker: Add subtree hashes to landmark bundle #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
approved these changes
Nov 3, 2025
Member
|
Note that this doesn't match the documented interface to expose landmarks. |
Member
|
I missed this in the previous round of reviews, but it's not ideal that there is quite a bit of duplication in this API: we need to check that the end of one subtree matches the start of the next; and that the treesize of the checkpoint matches end-1 of the last subtree. |
Contributor
Author
|
I'll update the docs in this PR.
My understanding is that adjacent subtrees may actually overlap a bit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.