Skip to content

mtc_api: Properly encode TBSCertificateLogEntry #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjpatton merged 1 commit into from
Nov 6, 2025
Merged

mtc_api: Properly encode TBSCertificateLogEntry #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions crates/mtc_api/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ use x509_cert::{
certificate::Version,
ext::{
pkix::{ExtendedKeyUsage, KeyUsage, KeyUsages},
Extension,
Extension, Extensions,
},
name::RdnSequence,
name::{Name, RdnSequence},
serial_number::SerialNumber,
spki::{AlgorithmIdentifier, SubjectPublicKeyInfo},
time::Validity,
Expand Down Expand Up @@ -355,14 +355,24 @@ impl MerkleTreeCertEntry {

#[derive(Clone, Debug, Eq, PartialEq, Sequence, ValueOrd)]
pub struct TbsCertificateLogEntry {
/// The certificate version
///
/// Note that this value defaults to Version 1 per the RFC. However,
/// fields such as `issuer_unique_id`, `subject_unique_id` and `extensions`
/// require later versions. Care should be taken in order to ensure
/// standards compliance.
#[asn1(context_specific = "0", default = "Default::default")]
pub version: Version,
pub issuer: RdnSequence,
pub issuer: Name,
pub validity: Validity,
pub subject: RdnSequence,
pub subject: Name,
pub subject_public_key_info_hash: OctetString,
#[asn1(context_specific = "1", tag_mode = "IMPLICIT", optional = "true")]
pub issuer_unique_id: Option<BitString>,
#[asn1(context_specific = "2", tag_mode = "IMPLICIT", optional = "true")]
pub subject_unique_id: Option<BitString>,
pub extensions: Option<Vec<Extension>>,
#[asn1(context_specific = "3", tag_mode = "EXPLICIT", optional = "true")]
pub extensions: Option<Extensions>,
}

// Validate and filter extended key usage extension.
Expand Down