MTC: Cache landmark bundle and optimize computation #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
approved these changes
Nov 18, 2025
Contributor
cjpatton
left a comment
cjpatton
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor things
rozbb
force-pushed
the
cache-landmark-bundle
branch
from
32191e5 to
839e843
Compare
* Started moving landmark bundle comptuation to cronjob * Fix type signature of CheckpointCallbacker to let the landmark bundle creator access the checkpoint bytes * Save the landmark bundle in R2 * Make landmark subtrees endpoint fetch from R2 * Return get-landmark-bundle directly from R2 * Implement cached bucket backend
rozbb
force-pushed
the
cache-landmark-bundle
branch
from
839e843 to
661a36a
Compare
rozbb
commented
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MTC's
/get-landmark-bundleendpoint can take up to 30sec to return a bundle response.This PR:
This does introduce a potential bug, though. If the landmark sequence and landmark bundle PUT operations do not both succeed, then we will end up in an illegal state, where the sequence and bundle don't match each other. I made a tracking issue for workers-rs here.. The issue also includes a workaround, but it's nasty.