Add clippy to CI

.github/workflows/rust.yml

@@ -16,6 +16,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v4
+    - name: Clippy
+      run: cargo clippy -- -D warnings
     - name: Build
       run: cargo build --verbose
     - name: Run tests

crates/generic_log_worker/src/lib.rs

@@ -364,7 +364,7 @@ fn serialize_entries(entries: &[(LookupKey, SequenceMetadata)]) -> Vec<u8> {
 }
 
 fn deserialize_entries(buf: &[u8]) -> Result<Vec<(LookupKey, SequenceMetadata)>> {
-    if buf.len() % 32 != 0 {
+    if !buf.len().is_multiple_of(32) {
         return Err("invalid buffer length".into());
     }
     let mut entries = Vec::with_capacity(buf.len() / 32);

crates/generic_log_worker/src/log_ops.rs

@@ -612,7 +612,7 @@ pub async fn prove_subtree_consistency(
     let proof = tlog_tiles::subtree_consistency_proof(cur_tree_size, m, &hash_reader)?;
 
     // Compute the subtree hash.
-    let subtree_hash = tlog_tiles::subtree_hash(&m, &hash_reader)?;
+    let subtree_hash = tlog_tiles::subtree_hash(m, &hash_reader)?;
     Ok((proof, subtree_hash))
 }