Skip to content

Conversation

@mendess
Copy link
Contributor

@mendess mendess commented Nov 27, 2025

No description provided.

@mendess mendess self-assigned this Nov 27, 2025
@mendess mendess force-pushed the mendess/support-wshim-metrics branch from d4370ab to 67ad8cf Compare November 27, 2025 14:09
@mendess mendess force-pushed the mendess/support-wshim-metrics branch from 67ad8cf to 67cd40b Compare November 28, 2025 11:13
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noooicce! Just one minor comment.

@rozbb can you test out ct_worker? I've already tested mtc_worker.

@cjpatton cjpatton requested a review from rozbb December 1, 2025 19:39
Copy link
Contributor

@rozbb rozbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably dumb question, but I'm not familiar with this pattern: what is a wshim and what is it intended to do? My guess: it is an object that knows how to serialize a log/registry/whatever to a particular endpoint that can be used for monitoring.

Another dumb question: why is this necessary when wrangler tail exists? Is this a common workaround to some known limitations in wrangler tail? Could it possibly be moved into a library eventually?

Finally, it'd be nice to have some comments explaining what's happening. This PR meaningfully increases complexity due to mutability and scoping tricks. It'd be good to make sure this is explained fully. And hopefully, written in a way that it can eventually be removed once we get a better logging story for wrangler.

@rozbb
Copy link
Contributor

rozbb commented Dec 1, 2025

Noooicce! Just one minor comment.

@rozbb can you test out ct_worker? I've already tested mtc_worker.

npx wrangler dev -e dev followed by python3 scripts/add_cert_to_local_dev.py seems to work. That is, the request is a success and the tree eventually has 1 item.

@mendess mendess force-pushed the mendess/support-wshim-metrics branch from 67cd40b to 341565b Compare December 2, 2025 15:10
@mendess mendess force-pushed the mendess/support-wshim-metrics branch from 341565b to e29901b Compare December 3, 2025 11:27
@mendess mendess merged commit 43b909d into main Dec 4, 2025
1 check passed
@mendess mendess deleted the mendess/support-wshim-metrics branch December 4, 2025 12:16
lbaquerofierro pushed a commit to lbaquerofierro/azul that referenced this pull request Jan 8, 2026
lbaquerofierro pushed a commit to lbaquerofierro/azul that referenced this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants