fix clippy lints surfaced by Rust 1.98 - #276
Merged
Merged
Conversation
CI runs clippy from the latest stable, which advanced to 1.98 and added new lints: - tlog_tiles_wasm: use slice::as_chunks instead of chunks_exact with a const size (chunks_exact_to_as_chunks), dropping the try_into unwrap. - tlog_tiles: use u64::isolate_lowest_one in a test (manual_isolate_lowest_one). - generic_log_worker: allow unused_async_trait_impl on the test storage backends, whose async trait signatures require the impls stay async even without an await.
lukevalenta
requested review from
a team,
bwesterb,
cjpatton,
lbaquerofierro and
mendess
as code owners
August 20, 2026 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI runs clippy from the latest stable (
rustup update stable), which advanced to 1.98 and started failing the requiredcargo clippy -- -D warningsjob on pre-existing code.slice::as_chunks::<32>()instead ofchunks_exact(32)(chunks_exact_to_as_chunks), which also drops thetry_into().unwrap().u64::isolate_lowest_one()in a test (manual_isolate_lowest_one).#![allow(clippy::unused_async_trait_impl)]on the test storage backends, whoseasync fntrait signatures require the impls stayasynceven without anawait.Verified locally on 1.98:
cargo clippy -- -D warnings, workspace-Dclippy::pedantic,cargo test,cargo fmt --all --check, andcargo shearall pass.