Skip to content

Clean up and refactor in preparation for tlog CA #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukevalenta merged 11 commits into from
May 13, 2025
Merged

Clean up and refactor in preparation for tlog CA #35

lukevalenta merged 11 commits into from
May 13, 2025

Conversation

@lukevalenta
Copy link
Contributor

@lukevalenta lukevalenta commented May 13, 2025 •
edited
Loading

  • a418754 Unify errors in static_ct_api crate
  • d869cb4 Add crate for reusable x509 chain operations
  • ef99499 Add crate for reading and writing big-endian length-prefixed bytes
  • d06bebd Move compute_cache_hash to LogEntry::lookup_key
  • 7f8176d Rename CacheKey->LookupKey and CacheValue->SequenceMetadata
  • bad5891 Remove wrapper around load_pem_chain from static_ct_api
  • 6643dc8 Add units for config default functions

@lukevalenta lukevalenta requested a review from cjpatton May 13, 2025 14:32
@lukevalenta lukevalenta self-assigned this May 13, 2025
@lukevalenta
Move compute_cache_hash to LogEntry::lookup_key
d06bebd
@lukevalenta
Add crate for reading and writing big-endian length-prefixed bytes
ef99499 
* Add length_prefixed crate, and use it in static_ct_api
* Make byteorder a workspace dependency
@lukevalenta
Add crate for reusable x509 chain operations
d869cb4
@lukevalenta
Unify errors in static_ct_api crate
a418754 
- Add Result and Error types to the static_ct_api crate, and just expose
  a single error type from the crate.
- Modify log_id_from_key to just panic if decoding the verifying key
  fails.
cjpatton
cjpatton approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! You've got documentation conventions down pat.

@lukevalenta
Copy link
Contributor Author

lukevalenta commented May 13, 2025

Beautiful! You've got documentation conventions down pat.

Heh, just a very strict linter :).

@lukevalenta lukevalenta merged commit d269d1d into main May 13, 2025
1 check passed
@lukevalenta lukevalenta deleted the lvalenta/cleanup branch May 13, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjpatton cjpatton cjpatton approved these changes

Assignees

@lukevalenta lukevalenta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukevalenta @cjpatton