Add TlogTile wrapper around Tile to implement tlog-tiles spec #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tile struct supports the tile format used by the Go checksum library (from which it was ported), but the tlog-tiles spec makes a few changes. Specifically, it fixes the height at 8 (so each tile has 256 elements), and uses the path element "entries" for data tiles. With this change, we can remove custom path logic from the static_ct_api crate, although we still need to use the path element "data". I don't love the "data_path_opt" field in tiles, but this seems like an OK way to support both "data" and "entries" as the data path element.
cjpatton
approved these changes
May 14, 2025
* Support non-data data path elements * Support paths without height element * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tile struct supports the tile format used by the Go checksum library (from which it was ported), but the tlog-tiles spec makes a few changes. Specifically, it fixes the height at 8 (so each tile has 256 elements), and uses the path element "entries" for data tiles.
With this change, we can remove custom path logic from the static_ct_api crate, although we still need to use the path element "data".
I don't love the "data_path_opt" field in tiles, but this seems like an OK way to support both
"data"and"entries"as the data path element.It will also allow us to support non-standard data tile paths like
"extra_data", if we so choose.