Skip to content

Conversation

@lukevalenta
Copy link
Contributor

  • Use '&[u8]' (which implements Read) instead of Cursor where applicable
  • Clean up SCT extensions parsing
  • Clean up chain_fingerprints parsing
  • Add enum for EntryType (X509Cert or Precert) and use where applicable
  • Create PrecertData wrapper around fields that are only present in precerts, put an optional in StaticCTPendingLogEntry. The presence of the optional indicates whether the entry is a cert or precert.
  • Make validate_chain return a StaticCTPendingLogEntry and remove ValidatedChain struct. And there's no need for validate_chain to return the raw issuers since the caller already has the raw chain.
  • Use tlog_tiles::LookupKey instead of static_ct_api::LookupKey

* Use '&[u8]' (which implements Read) instead of Cursor where applicable
* Clean up SCT extensions parsing
* Clean up chain_fingerprints parsing
* Add enum for EntryType (X509Cert or Precert) and use where applicable
* Create PrecertData wrapper around fields that are only present in
  precerts, put an optional in StaticCTPendingLogEntry. The presence of
  the optional indicates whether the entry is a cert or precert.
* Make validate_chain return a StaticCTPendingLogEntry and remove
  ValidatedChain struct. And there's no need for validate_chain to
  return the raw issuers since the caller already has the raw chain.
* Use tlog_tiles::LookupKey instead of static_ct_api::LookupKey
@lukevalenta lukevalenta requested a review from cjpatton June 5, 2025 21:01
@lukevalenta lukevalenta merged commit fb4f44d into main Jun 6, 2025
1 check passed
@lukevalenta lukevalenta deleted the lvalenta/cleanup-parsing branch June 6, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants