Add log.v3.json endpoint and clean up handler, fixes #41 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukevalenta
commented
Jun 24, 2025
lukevalenta
commented
- Add an outer Router in the fetch handler to check the log parameter, instead of requiring each handler to check that the requested log path is in the allowlist
- Change /metadata endpoint to /log.v3.json, dropping the witness_key field. The witness is just used to exercise the code path, and it's not expected that any clients would actually use the endpoint.
- Disable bucket access via the Worker if monitoring_url is specified so clients must use the intended monitoring API endpoint.
- Update MMD to 60 as that's the max allowed in Chrome's CT program for static CT logs. (Note that this is effectively zero in the current implementation.)
bwesterb
reviewed
Jun 24, 2025
bwesterb
approved these changes
Jun 24, 2025
- Add an outer Router in the fetch handler to check the log parameter, instead of requiring each handler to check that the requested log path is in the allowlist - Change /metadata endpoint to /log.v3.json, dropping the witness_key field. The witness is just used to exercise the code path, and it's not expected that any clients would actually use the endpoint. - Disable bucket access via the Worker if monitoring_url is specified so clients must use the intended monitoring API endpoint. - Update MMD to 60 as that's the max allowed in Chrome's CT program for static CT logs. (Note that this is effectively zero in the current implementation.)
lukevalenta
force-pushed
the
lvalenta/log-v3-endpoint
branch
from
fd8fcce to
d6ec811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.