Update to worker 0.6.0, addressing breaking changes #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukevalenta
commented
Jul 17, 2025
lukevalenta
commented
- Durable Object methods no longer take a mutable reference, so we need to use interior mutability (RefCell) to update state, as recommended by the workers-rs maintainers. The tricky part is avoiding passing a borrowed Ref to an async function, as that could cause a panic if, for example, a concurrent async operation attempts to borrow an already-mutably-borrowed value.
- To simplify the above change, remove the Option wrapper from the GenericSequencer's 'sequence_state' field. Instead of loading the sequencer state just-in-time for the first sequencing, load it during the DO initialization (which happens after the first fetch or alarm). Similarly, when there is a fatal sequencing error requiring reloading the sequence state, load the state right away rather than waiting for the next sequencing.
Contributor
Author
|
@rozbb fyi |
- Durable Object methods no longer take a mutable reference, so we need to use interior mutability (RefCell) to update state, as recommended by the workers-rs maintainers. The tricky part is avoiding passing a borrowed Ref to an async function, as that could cause a panic if, for example, a concurrent async operation attempts to borrow an already-mutably-borrowed value. - To simplify the above change, remove the Option wrapper from the GenericSequencer's 'sequence_state' field. Instead of loading the sequencer state just-in-time for the first sequencing, load it during the DO initialization (which happens after the first fetch or alarm). Similarly, when there is a fatal sequencing error requiring reloading the sequence state, load the state right away rather than waiting for the next sequencing.
lukevalenta
force-pushed
the
lvalenta/worker-0.6.0
branch
from
fe6b7a4 to
286cd54
Compare
bwesterb
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.