Skip to content

ci: tolerate missing preview URL output - #261

Closed
yomna-shousha wants to merge 1 commit into
cloudflare:mainfrom
yomna-shousha:fix-preview-docs-url-output
Closed

ci: tolerate missing preview URL output#261
yomna-shousha wants to merge 1 commit into
cloudflare:mainfrom
yomna-shousha:fix-preview-docs-url-output

Conversation

@yomna-shousha

Copy link
Copy Markdown

Summary

  • tolerate Wrangler preview output that omits preview/deployment URL arrays
  • derive fallback preview and deployment URLs from preview_slug/deployment_id while keeping custom preview names working

Verification

  • reproduced the existing jq failure with successful preview output missing URL arrays: exit=4
  • verified the updated jq filter against failed-log output shape
  • verified it still handles previous output with preview_urls/deployment_urls
  • verified custom preview_slug fallback output
  • ran git diff --check

@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 082e055

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/capnweb@261
npm i https://pkg.pr.new/cloudflare/capnweb/capnweb-validate@261

commit: 082e055

@yomna-shousha

Copy link
Copy Markdown
Author

Closing this because deriving preview URLs in the workflow would mask the real problem: Wrangler is not returning preview/deployment URLs, and the expected preview hostnames do not resolve.

@yomna-shousha
yomna-shousha deleted the fix-preview-docs-url-output branch September 4, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant