-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs Site] Add Turnstile and track referrer in feedback prompt #19581
Conversation
@@ -39,7 +39,7 @@ | |||
"@codingheads/sticky-header": "1.0.2", | |||
"@expressive-code/plugin-collapsible-sections": "0.38.3", | |||
"@iarna/toml": "2.2.5", | |||
"@iconify-json/material-symbols": "1.2.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only ever used by FeedbackPrompt.astro
which is no-longer an Astro component, it now uses react-icons
.
@@ -16,7 +16,6 @@ export { default as Example } from "./Example.astro"; | |||
export { default as ExternalResources } from "./ExternalResources.astro"; | |||
export { default as Feature } from "./Feature.astro"; | |||
export { default as FeatureTable } from "./FeatureTable.astro"; | |||
export { default as FeedbackPrompt } from "./FeedbackPrompt.astro"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not worth having this in the barrel file as it isn't used outside of overrides.
@@ -1,10 +1,8 @@ | |||
--- | |||
import type { Props } from "@astrojs/starlight/props"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused since MarkdownContent
takes no props.
--- | ||
|
||
{ | ||
tableOfContents === false && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done with the data-has-toc
attribute on html
instead (and Prettier can't format this).
|
||
<style> | ||
html:not([data-has-sidebar]) { | ||
--sl-content-width: 80rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been unused for awhile as other widths had more specificity.
|
||
<style> | ||
html:not([data-has-sidebar]) { | ||
--sl-content-width: 75rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been unused for awhile as other widths had more specificity.
@@ -156,6 +156,9 @@ export default { | |||
600: "var(--tw-accent-600)", | |||
900: "var(--tw-accent-900)", | |||
}, | |||
sl: { | |||
DEFAULT: "var(--sl-color-text)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a shortcut for getting the gray colour used by text, regardless of light or dark mode.
Deploying cloudflare-docs with
|
Latest commit: |
7181456
|
Status: | ✅ Deploy successful! |
Preview URL: | https://beaee288.cloudflare-docs-7ou.pages.dev |
Branch Preview URL: | https://kian-pcx-15597.cloudflare-docs-7ou.pages.dev |
…dflare#19581) * [Docs Site] Add Turnstile and track referrer in feedback prompt * remove debug logs * remove unused import
Summary
Rewrites feedback prompt to be a React component.
Adds Turnstile and tracks the referrer on submissions.