Cancel in-progress production builds #26711
Closed
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://4d0d438b.preview.developers.cloudflare.com |
Collaborator
|
We don't want this. If you cancel in progress builds, you can get into an endless queuing situation where you might then wait longer for something to publish. Seen this happen quite a lot in other contexts (search indexing, for example) and it can be maddening. In progress builds also have no effect on the speed / queues for other builds. Happy to provide more context or discuss more if I'm missing something here. Just let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We already put PRs in concurrency groups so that new pushes cancel in-progress builds, but we don't do that for production. This PR changes it so that new merges to production cancel any in-progress builds. We only care about the most recent commit, so it's wasteful to keep running builds that will be out of date very soon.
Screenshots (optional)
Documentation checklist