[Site] Restructure footer so semantic footer is within it

[kodster28]

Summary

We have footer content that's actually outside the footer container. Updating our override to account for this.

[github-actions]

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern	Owners
*.astro	@cloudflare/content-engineering, @kodster28
*.ts	@cloudflare/content-engineering, @kodster28

[github-actions]

Preview URL: https://a6e2288f.preview.developers.cloudflare.com
Preview Branch URL: https://footer-reorg.preview.developers.cloudflare.com

[elithrar]

/bonk review this PR for @kodster28

[ask-bonk]

Now I have a complete understanding of the changes. Let me write up the review.

---

PR Review: [Site] Restructure footer so semantic footer is within it

Summary of Changes

src/components/overrides/Footer.astro (+90/-60): The core of the PR. Previously, the Footer override component rendered the custom Cloudflare footer content (link groups, copyright, etc.) outside of the <footer> element -- it imported and rendered the default Starlight <Default /> (which contains the <footer> tag) as a sibling, with the custom content alongside it. Now, everything is wrapped inside a single <footer class="sl-flex"> element that the component owns directly.

Key structural changes:

• Removed: import Default from "@astrojs/starlight/components/Footer.astro" and the {!splash && <Default />} usage.
• Added: Explicit imports of the sub-components that Default was rendering internally: EditLink, LastUpdated, and Pagination (via virtual:starlight/components/* modules).
• The custom Cloudflare footer section, the Starlight meta section (pagination + edit link + last updated), and the feedback prompt are all now children of a single <footer> element.
• Styles updated: :global(footer:not(.DocSearch-Footer)) selector replaced with a simpler scoped footer selector. The .meta override no longer needs :global() wrapping. Added explicit padding/margin to .starlight-footer-section and .feedback-prompt since the layout is now self-contained.

src/starlight-modules.d.ts (+17, new file): Adds TypeScript type declarations for the three virtual:starlight/components/* modules now imported directly. Without this, TS would complain about unresolved modules.

Feedback

Overall: This looks good. The motivation is clear and the approach is sound.

A few observations:

1. Semantic correctness: The whole point of this PR is well-justified. Having footer content visually appearing in the footer but semantically outside the <footer> landmark is an accessibility issue. Wrapping everything in a single <footer> is the right call.

2. Type declarations file (src/starlight-modules.d.ts): This is fine and necessary given the virtual module imports. It's automatically included via the "include": [".astro/types.d.ts", "**/*"] in tsconfig.json, so no config changes are needed.

   One minor note: the type references like typeof import("@astrojs/starlight/components/EditLink.astro").default assume the shape of Starlight's internal component exports. These could break on a Starlight major version upgrade, but that's inherent to overriding framework internals and is acceptable for this use case.

3. :global() removal: The old code needed :global(footer:not(.DocSearch-Footer)) because the footer element was rendered by the imported Default component (outside the scope of this component's styles). Now that the <footer> is directly in this component's template, the scoped footer selector works naturally. Clean improvement.

4. Hardcoded copyright year: Line 115 has © 2026 Cloudflare, Inc. -- this was already present before the PR so it's not a regression, but worth noting it'll need a manual bump each year. Not something to block this PR on.

5. Discord link uses HTTP: Line 50 has http://discord.cloudflare.com/ -- again, pre-existing and not introduced by this PR.

No blocking issues found. The restructuring is well-scoped, the styles are appropriately simplified, and the new type declarations are correct.

github run