[Images] Add backend clarification for signed image URLs#28258
Merged
ToriLindsay merged 4 commits intoproductionfrom Feb 19, 2026
Merged
[Images] Add backend clarification for signed image URLs#28258ToriLindsay merged 4 commits intoproductionfrom
ToriLindsay merged 4 commits intoproductionfrom
Conversation
ToriLindsay
requested review from
a team,
renandincer and
third774
as code owners
github-actions
bot
added
product:images
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://cbaef703.preview.developers.cloudflare.com Files with changes (up to 15) |
elithrar
reviewed
Feb 11, 2026
Collaborator
There was a problem hiding this comment.
/bonk improve this example - we should be guiding users to use wrangler secret or Secrets Store for handling key material, not baking into source code.
review the rest for clarity and make fixes.
- Replace hardcoded KEY constant with env.IMAGES_SIGNING_KEY binding - Add note guiding users to store keys via wrangler secret put - Fix event.request.url bug (should be request.url in fetch handler) - Add TypeScript types to function signatures - Minor clarity improvements to prose and code comments
Contributor
|
Here is a summary of all changes made: Key material handling (reviewer's primary concern)
Bug fix
Clarity improvements
|
ranbel
reviewed
Feb 18, 2026
src/content/docs/images/manage-images/serve-images/serve-private-images.mdx
Outdated
Show resolved
Hide resolved
ranbel
approved these changes
Feb 18, 2026
Co-authored-by: ranbel <101146722+ranbel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clarification that Worker example can be implemented in any backend stack based on user feedback.