chore: add pull_request_review trigger to Bonk workflow#28436
Open
irvinebroque wants to merge 1 commit intoproductionfrom
Open
chore: add pull_request_review trigger to Bonk workflow#28436irvinebroque wants to merge 1 commit intoproductionfrom
irvinebroque wants to merge 1 commit intoproductionfrom
Conversation
Reviews submitted via 'Submit review' fire pull_request_review events, not pull_request_review_comment or issue_comment. The Bonk action already handles this event type — this just wires it up as a trigger.
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Preview URL: https://7dea1c8b.preview.developers.cloudflare.com |
elithrar
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pull_request_review(type:submitted) as a workflow trigger for the Bonk workflow.Why this is needed
Real examples of
/bonknot triggering:#28432 (review)
#28434 (review)
The workflow already triggers on
pull_request_review_comment, but that is a different GitHub event. GitHub has three distinct comment-related events on PRs:issue_commentpull_request_review_comment+on a diff line and commentingpull_request_reviewThe workflow already had the first two, but not the third. When someone writes
/bonkin the review body and hits "Submit review", GitHub fires apull_request_reviewevent — notpull_request_review_commentorissue_comment. Without this trigger, that/bonkis silently ignored.This is exactly what happened here — a
/bonksubmitted as a PR review at 2026-02-19T00:53:35Z never triggered the workflow because the event type wasn't in the trigger list.What this changes
Two lines added to
.github/workflows/bonk.yml:No other changes needed — the ask-bonk action already handles this event type (reads
$REVIEW_BODYand skips the reaction since the GitHub REST API doesn't support reactions on review submissions).Note: Because the REST API doesn't support reactions on PR reviews, there won't be a 👍 ack on the review itself when Bonk picks it up. The work will still proceed normally.