[AIG-1532] Add a gateway-level setting to force BYOK - #33229
Open
superhighfives wants to merge 2 commits into
Open
[AIG-1532] Add a gateway-level setting to force BYOK#33229superhighfives wants to merge 2 commits into
superhighfives wants to merge 2 commits into
Conversation
superhighfives
requested review from
a team,
aninibread,
ethulia,
kathayl,
kflansburg,
mattrothenberg,
mchenco,
palashgo,
roerohan,
shridhar-cf and
zeke
as code owners
September 4, 2026 16:16
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #33229 (https://github.com/cloudflare/cloudflare-docs/pull/33229).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (3)
#### CR-f8e1e03c9741 · Factually contradictory billing claim
- **File:** `src/content/docs/ai-gateway/configuration/manage-gateway.mdx` line 87
- **Issue:** The new sentence states Workers AI requests "use standard Workers AI account billing, not AI Gateway Unified Billing." The "Configure Workers AI billing" section on the same page (above) instructs users to select **Unified billing** so that "Workers AI requests routed through this gateway will deduct from your AI Gateway credit balance" — so Workers AI requests *can* use AI Gateway Unified Billing depending on the gateway's Workers AI billing setting. As written, the new sentence is incorrect for any gateway configured with Unified billing and contradicts the page's own instructions.
- **Fix:** Clarify that the statement refers to the default billing mode or to the Unified Billing fallback that this setting disables, e.g. "They use the gateway's configured Workers AI billing mode (standard or unified) — this setting only disables the Unified Billing fallback for third-party provider requests."
#### CR-812563c4074b · Contradicts page's own billing docs
- **File:** `src/content/docs/ai-gateway/features/unified-billing.mdx` line 97
- **Issue:** The added text claims Workers AI requests "use standard Workers AI account billing, not AI Gateway Unified Billing," but the same page's "Use Unified Billing" section states that when the gateway's Workers AI Billing setting is set to "Unified billing," Workers AI requests routed through that gateway deduct from the prepaid credit balance. The two statements conflict for users with that configuration.
- **Fix:** Reword to avoid the billing claim, e.g. clarify that this setting does not block Workers AI requests and that Workers AI billing follows the gateway's Workers AI Billing configuration (which can be Unified billing), or otherwise reconcile the statement with the earlier section.
#### CR-6a4c326489e8 · Inaccurate categorical claim contradicts same page
- **File:** `src/content/docs/ai-gateway/configuration/manage-gateway.mdx` line 87
- **Issue:** The added line states Workers AI requests "use standard Workers AI account billing, not AI Gateway Unified Billing" as an unconditional fact, but the same page's "Configure Workers AI billing" section documents a gateway setting that switches Workers AI requests to Unified billing ("Workers AI requests routed through this gateway will deduct from your AI Gateway credit balance in real time"), and unified-billing.mdx lists "To use credits for Workers AI, set your gateway's Workers AI Billing setting to Unified billing" as a prerequisite. The statement is only true for the default (Standard billing) configuration.
- **Fix:** Qualify the claim, e.g. "By default they use standard Workers AI account billing; if the gateway's Workers AI Billing setting is set to Unified billing, they use AI Gateway Unified Billing instead." This setting itself does not change Workers AI billing.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (3)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-aig-1532-ai-gateway-byok-only.previews.developers.cloudflare.com (commit 02ffdee)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
superhighfives
force-pushed
the
docs/AIG-1532-ai-gateway-byok-only
branch
from
September 8, 2026 13:19
a2d9717 to
02ffdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a gateway-level setting that forces third-party requests to use customer-provided credentials instead of falling back to Unified Billing.
Jira: https://jira.cfdata.org/browse/AIG-1532