[Custom Errors] Add bandwidth warning for large custom error assets - #33298
Merged
Conversation
Contributor
Review💡 1 suggestion found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33298 (https://github.com/cloudflare/cloudflare-docs/pull/33298).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Style Guide Review
### Suggestions (1)
#### SG-6fe168da3848 · Passive voice
- **File:** `src/content/docs/rules/custom-errors/index.mdx` line 106
- **Issue:** "a custom error asset is served to every visitor" and "external URLs are fetched and inlined as well" use passive voice; the actor (Cloudflare) is known and used as subject in the preceding clause
- **Fix:** Rewrite in active voice, e.g. "Cloudflare serves a custom error asset to every visitor that triggers the associated rule... Cloudflare inlines referenced resources when fetching the asset, and also fetches and inlines external URLs."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-custom-errors-bandwidth.previews.developers.cloudflare.com (commit 8fe1436)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
|
Preview URL: https://8fe1436a.preview.developers.cloudflare.com Files with changes (up to 15)
|
mbullock1986
enabled auto-merge (squash)
September 8, 2026 12:36
mbullock1986
force-pushed
the
docs-custom-errors-bandwidth
branch
from
September 8, 2026 14:33
8d80cfc to
fbfdb93
Compare
mbullock1986
force-pushed
the
docs-custom-errors-bandwidth
branch
from
September 8, 2026 16:25
fbfdb93 to
8fe1436
Compare
smarsh-cf
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a caution note to the Custom Error Assets size limits section warning that large assets are served on every matching error and can generate significant egress traffic. Recommends keeping assets small and avoiding inlined large resources.