Cache key - Cache by device type APO - #33300
Open
tomislavcf wants to merge 1 commit into
Open
Conversation
tomislavcf
requested review from
a team,
ack-cf,
mbullock1986 and
zaidoon1
as code owners
September 8, 2026 13:48
Contributor
Review💡 2 suggestions found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33300 (https://github.com/cloudflare/cloudflare-docs/pull/33300).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-e8712791976d · Factual claim conflicts with linked reference page
- **File:** `src/content/docs/cache/how-to/cache-keys.mdx` line 163
- **Issue:** The note states "Enabling APO automatically adds device type to the cache key", but the linked page (/automatic-platform-optimization/reference/cache-device-type/) describes cache by device type as an opt-in setting: "To enable caching by device type, enable the setting from the Cloudflare dashboard's APO card or from the WordPress plugin version 4.4.0 or later." The phrasing also makes it ambiguous whether "Enabling APO" means enabling APO itself or enabling APO's cache-by-device-type toggle.
- **Fix:** Rephrase to match the referenced page, e.g. "Enabling APO's cache by device type setting adds device type to the cache key", and confirm with the product owner that enabling APO alone (without the toggle) does not add device type to the cache key.
---
## Style Guide Review
### Suggestions (1)
#### SG-34677b4251f8 · Semicolon joining independent clauses
- **File:** `src/content/docs/cache/how-to/cache-keys.mdx` line 163
- **Issue:** Line 163 uses a semicolon to join two independent clauses: "...adds [device type] to the cache key; Cache Rules lets you configure this manually..."
- **Fix:** Break into two sentences, e.g. "Enabling APO automatically adds device type to the cache key. Cache Rules lets you configure this manually for non-APO zones."
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add link for Cache by device type from APO's page https://developers.cloudflare.com/automatic-platform-optimization/reference/cache-device-type/ to the Cache key page https://developers.cloudflare.com/cache/how-to/cache-keys/#cache-key-settings as a note since it used the same codebase.