Skip to content

Cache key - Cache by device type APO - #33300

Open
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-7
Open

Cache key - Cache by device type APO#33300
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-7

Conversation

@tomislavcf

Copy link
Copy Markdown
Contributor

Add link for Cache by device type from APO's page https://developers.cloudflare.com/automatic-platform-optimization/reference/cache-device-type/ to the Cache key page https://developers.cloudflare.com/cache/how-to/cache-keys/#cache-key-settings as a note since it used the same codebase.

@github-actions github-actions Bot added product:cache Issues or PRs related to Cache size/xs labels Sep 8, 2026
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review

💡 2 suggestions found in commit c2c725c.

👉 Fix in your agent 👈
Fix the following review findings in PR #33300 (https://github.com/cloudflare/cloudflare-docs/pull/33300).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (1)

#### CR-e8712791976d · Factual claim conflicts with linked reference page
- **File:** `src/content/docs/cache/how-to/cache-keys.mdx` line 163
- **Issue:** The note states "Enabling APO automatically adds device type to the cache key", but the linked page (/automatic-platform-optimization/reference/cache-device-type/) describes cache by device type as an opt-in setting: "To enable caching by device type, enable the setting from the Cloudflare dashboard's APO card or from the WordPress plugin version 4.4.0 or later." The phrasing also makes it ambiguous whether "Enabling APO" means enabling APO itself or enabling APO's cache-by-device-type toggle.
- **Fix:** Rephrase to match the referenced page, e.g. "Enabling APO's cache by device type setting adds device type to the cache key", and confirm with the product owner that enabling APO alone (without the toggle) does not add device type to the cache key.

---

## Style Guide Review

### Suggestions (1)

#### SG-34677b4251f8 · Semicolon joining independent clauses
- **File:** `src/content/docs/cache/how-to/cache-keys.mdx` line 163
- **Issue:** Line 163 uses a semicolon to join two independent clauses: "...adds [device type] to the cache key; Cache Rules lets you configure this manually..."
- **Fix:** Break into two sentences, e.g. "Enabling APO automatically adds device type to the cache key. Cache Rules lets you configure this manually for non-APO zones."

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (1)
File Issue
cache/how-to/cache-keys.mdx line 163 Factual claim conflicts with linked reference page — The note states "Enabling APO automatically adds device type to the cache key", but the linked page (/automatic-platform-optimization/reference/cache-device-type/) describes cache by device type as an opt-in setting: "To enable caching by device type, enable the setting from the Cloudflare dashboard's APO card or from the WordPress plugin version 4.4.0 or later." The phrasing also makes it ambiguous whether "Enabling APO" means enabling APO itself or enabling APO's cache-by-device-type toggle. Fix: Rephrase to match the referenced page, e.g. "Enabling APO's cache by device type setting adds device type to the cache key", and confirm with the product owner that enabling APO alone (without the toggle) does not add device type to the cache key.

Conventions

No convention issues found.

Style Guide Review

Suggestions (1)
File Issue
cache/how-to/cache-keys.mdx line 163 Semicolon joining independent clauses — Line 163 uses a semicolon to join two independent clauses: "...adds [device type] to the cache key; Cache Rules lets you configure this manually..." Fix: Break into two sentences, e.g. "Enabling APO automatically adds device type to the cache key. Cache Rules lets you configure this manually for non-APO zones."
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:cache Issues or PRs related to Cache size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants