Skip to content

Cache keys - update note with link about mentioning cache by device type - #33301

Open
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-8
Open

Cache keys - update note with link about mentioning cache by device type#33301
tomislavcf wants to merge 1 commit into
cloudflare:productionfrom
tomislavcf:patch-8

Conversation

@tomislavcf

Copy link
Copy Markdown
Contributor

Update the existing note where "cache by device type" is already mentioned with a link towards APO's sub-page about device type cache

@github-actions github-actions Bot added product:cache Issues or PRs related to Cache size/xs labels Sep 8, 2026
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review

💡 1 suggestion found in commit 78d00c0.

👉 Fix in your agent 👈
Fix the following review findings in PR #33301 (https://github.com/cloudflare/cloudflare-docs/pull/33301).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (1)

#### CR-7c47dc957b6a · Duplicated content should use a partial
- **File:** `src/content/docs/cache/how-to/cache-keys.mdx` line 47
- **Issue:** This note is a near-verbatim copy of the note already in src/content/docs/cache/how-to/cache-rules/settings.mdx, and the two copies have already drifted (this version adds the device-type link and changes 'Cache Key' capitalization). The repo convention for reusable content is src/content/partials/.
- **Fix:** Consider extracting this note into a partial under src/content/partials/cache/ and rendering it from both cache-keys.mdx and cache-rules/settings.mdx so the guidance stays in sync.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (1)
File Issue
cache/how-to/cache-keys.mdx line 47 Duplicated content should use a partial — This note is a near-verbatim copy of the note already in src/content/docs/cache/how-to/cache-rules/settings.mdx, and the two copies have already drifted (this version adds the device-type link and changes 'Cache Key' capitalization). The repo convention for reusable content is src/content/partials/. Fix: Consider extracting this note into a partial under src/content/partials/cache/ and rendering it from both cache-keys.mdx and cache-rules/settings.mdx so the guidance stays in sync.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:cache Issues or PRs related to Cache size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants