Conversation
xmflsct
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the documented behaviour of the 50 MB content scanning size limit on the
malicious uploads page, and documents the
cf.waf.content_scan.truncatedfield.The page currently states that all content objects in a request will be checked, and
that objects over 50 MB are partially scanned. That is accurate for a request carrying
a single content object, but not for multipart requests with several files. The 50 MB
budget applies to the request body as a whole, so in a multipart request the objects
share it. Once the limit is reached, the object that extends past it is not
scanned, and neither is any object that follows.
This matters because the omission is silent. Skipped objects are not counted in
cf.waf.content_scan.num_obj, do not appear incf.waf.content_scan.obj_results, anddo not set
cf.waf.content_scan.has_failed. A partly scanned request can thereforeproduce the same field values as a request that was fully scanned and found clean.
cf.waf.content_scan.truncatedis how customers should detect this case.Testing
Built locally with
pnpm run build(9006 pages, no errors) and confirmed:#size-limitanchor resolves#scanned-contentanchor is unchangedpnpm run format:checkpasses.