Skip to content

[Logs] Log Logpush dataset archive digest - #33431

Open
soheiokamoto wants to merge 1 commit into
productionfrom
sohei/logpush-dataset-build-digest
Open

soheiokamoto wants to merge 1 commit into
productionfrom
sohei/logpush-dataset-build-digest

Conversation

@soheiokamoto

Copy link
Copy Markdown
Contributor

Summary

Logs the downloaded Logpush dataset archive SHA-256 during documentation builds. This allows build logs to identify the exact generated archive without exposing source-system details.

Tests

  • pnpm run check
  • pnpm run lint
  • pnpm run format:core:check
  • pnpm run test

Logs the downloaded Logpush dataset archive SHA-256 during documentation builds.

This allows build logs to identify the exact generated archive without exposing source-system details.
@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
*.ts @cloudflare/content-engineering

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://sohei-logpush-dataset-build-digest.previews.developers.cloudflare.com (commit 238255d)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ed730493.previews.developers.cloudflare.com 238255d 2026-09-15T04:13:22.645Z Visit the dashboard ↗

@soheiokamoto
soheiokamoto marked this pull request as ready for review September 15, 2026 04:16
@soheiokamoto
soheiokamoto requested a review from a team as a code owner September 15, 2026 04:16
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No outstanding issues in commit 238255d.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.


Acknowledged by author (1)
Review File Issue Note
Code bin/fetch-logpush-datasets.ts line 101 File read into memory for hashing The author says the archive is a small build-time asset (~32 KiB), so a single bounded read after download is fine and streaming would add asynchronous error-handling complexity to a six-line change without a meaningful memory benefit; they will revisit if the archive grows.
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

Copy link
Copy Markdown
Contributor

@soheiokamoto

Copy link
Copy Markdown
Contributor Author

CR-1ea197232306: Skipping this suggestion. The archive is a small build-time documentation asset, currently about 32 KiB, and hashing requires one bounded read after download. Streaming would add asynchronous error-handling complexity to a six-line change without a meaningful memory benefit. We can revisit this if the archive grows materially.

@soheiokamoto

Copy link
Copy Markdown
Contributor Author

/review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant