[Logs] Log Logpush dataset archive digest - #33431
soheiokamoto wants to merge 1 commit into
Conversation
Logs the downloaded Logpush dataset archive SHA-256 during documentation builds. This allows build logs to identify the exact generated archive without exposing source-system details.
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://sohei-logpush-dataset-build-digest.previews.developers.cloudflare.com (commit 238255d)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Review✅ No outstanding issues in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. Acknowledged by author (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
Preview URL: https://238255dc.preview.developers.cloudflare.com |
|
CR-1ea197232306: Skipping this suggestion. The archive is a small build-time documentation asset, currently about 32 KiB, and hashing requires one bounded read after download. Streaming would add asynchronous error-handling complexity to a six-line change without a meaningful memory benefit. We can revisit this if the archive grows materially. |
|
/review |
Summary
Logs the downloaded Logpush dataset archive SHA-256 during documentation builds. This allows build logs to identify the exact generated archive without exposing source-system details.
Tests
pnpm run checkpnpm run lintpnpm run format:core:checkpnpm run test