Skip to content

chore: bump nimbus version to 0.14.1 - #33433

Merged
MohamedH1998 merged 2 commits into
productionfrom
chore/bump-nimbus-version
Sep 15, 2026
Merged

MohamedH1998 merged 2 commits into
productionfrom
chore/bump-nimbus-version

Conversation

@MohamedH1998

@MohamedH1998 MohamedH1998 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates Nimbus Docs from 0.11.0 to 0.14.1 and applies the corresponding integration migrations. This adds the Nimbus migration baseline, moves partial ID resolution into the generated Markdown configuration, updates the docs route to the current page-props API, and ignores the generated coordinates manifest.

Documentation checklist

@MohamedH1998
MohamedH1998 requested review from a team as code owners September 15, 2026 08:47
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No outstanding issues in commit 1449bc8.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.


Acknowledged by author (1)
Review File Issue Note
Code src/pages/[...slug].astro line 40 Removed partial-heading collection option The author says the warning is a false positive: nimbus-docs 0.14.1's getDocsPageProps accepts only the Astro global and recursively merges headings from <Render file="..." /> partials at build time (verified on a generated page), so restoring the removed partialHeadings argument would be type-invalid and duplicate the replacement mechanism.
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
* @cloudflare/product-owners
*.ts @cloudflare/content-engineering
package.json @cloudflare/content-engineering
*.astro @cloudflare/content-engineering

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 15, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://chore-bump-nimbus-version.previews.developers.cloudflare.com (commit 1449bc8)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://4d0d5e91.previews.developers.cloudflare.com 1449bc8 2026-09-15T09:36:08.749Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://5c062bfc.previews.developers.cloudflare.com 538f58d 2026-09-15T08:56:10.109Z Visit the dashboard ↗

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@MohamedH1998

MohamedH1998 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Skipping the warning because the reported regression is not present in Nimbus 0.14.1.

getDocsPageProps now accepts only the Astro global, and its public API states that headings from <Render file="..." /> partials are recursively merged at build time. The 0.14.1 implementation builds prepared heading records with mergePartialHeadings(...) and uses markdown.partialResolver to map Cloudflare's product/file IDs. The generated /r2/reference/wrangler-commands/ page also confirms that headings from partials/workers/wrangler-commands/r2.mdx are present in the TOC.

Restoring the removed partialHeadings argument would therefore be type-invalid and would duplicate the replacement mechanism.

@MohamedH1998
MohamedH1998 enabled auto-merge (squash) September 15, 2026 10:38
@MohamedH1998
MohamedH1998 merged commit 53c0f70 into production Sep 15, 2026
21 of 22 checks passed
@MohamedH1998
MohamedH1998 deleted the chore/bump-nimbus-version branch September 15, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants