Skip to content

[Security Insights] Add static bot IP file - #33446

Open
davejbax wants to merge 1 commit into
cloudflare:productionfrom
davejbax:davejbax/add-security-insights-bot-ips
Open

davejbax wants to merge 1 commit into
cloudflare:productionfrom
davejbax:davejbax/add-security-insights-bot-ips

Conversation

@davejbax

Copy link
Copy Markdown
Collaborator

For BotBase verification via the IP list process

Summary

This adds a static JSON file intended to serve as a public reference of the IPs we egress out of for security scanning as part of the Security Insights service.

Screenshots (optional)

N/A

Documentation checklist

N/A

For BotBase verification via the IP list process
@davejbax
davejbax requested a review from a team as a code owner September 15, 2026 16:19
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review

💡 1 suggestion found in commit 743ee98.

👉 Fix in your agent 👈
Fix the following review findings in PR #33446 (https://github.com/cloudflare/cloudflare-docs/pull/33446).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Suggestions (1)

#### CR-3fb1f699b77b · Unreferenced static asset
- **File:** `public/security/security-insights/static/bot-ips.json` line 1
- **Issue:** The new file is a standalone static asset under public/ with no references anywhere in the repo (searches for "bot-ips", "static/bot-ips.json", and the file's key fields return nothing), and the docs page that documents the Security Insights crawler (src/content/docs/fundamentals/reference/cloudflare-site-crawling.mdx) does not link to it.
- **Fix:** Optional: link the file from the Security Insights crawler documentation (or a Security Insights page) so customers can discover it, and note how/when the list is updated — otherwise the hand-maintained snapshot (hardcoded creationTime) will silently go stale.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Suggestions (1)
File Issue
public/security/security-insights/static/bot-ips.json line 1 Unreferenced static asset — The new file is a standalone static asset under public/ with no references anywhere in the repo (searches for "bot-ips", "static/bot-ips.json", and the file's key fields return nothing), and the docs page that documents the Security Insights crawler (src/content/docs/fundamentals/reference/cloudflare-site-crawling.mdx) does not link to it. Fix: Optional: link the file from the Security Insights crawler documentation (or a Security Insights page) so customers can discover it, and note how/when the list is updated — otherwise the hand-maintained snapshot (hardcoded creationTime) will silently go stale.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant