Conversation
For BotBase verification via the IP list process
Contributor
Review💡 1 suggestion found in commit 👉 Fix in your agent 👈Fix the following review findings in PR #33446 (https://github.com/cloudflare/cloudflare-docs/pull/33446).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Suggestions (1)
#### CR-3fb1f699b77b · Unreferenced static asset
- **File:** `public/security/security-insights/static/bot-ips.json` line 1
- **Issue:** The new file is a standalone static asset under public/ with no references anywhere in the repo (searches for "bot-ips", "static/bot-ips.json", and the file's key fields return nothing), and the docs page that documents the Security Insights crawler (src/content/docs/fundamentals/reference/cloudflare-site-crawling.mdx) does not link to it.
- **Fix:** Optional: link the file from the Security Insights crawler documentation (or a Security Insights page) so customers can discover it, and note how/when the list is updated — otherwise the hand-maintained snapshot (hardcoded creationTime) will silently go stale.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For BotBase verification via the IP list process
Summary
This adds a static JSON file intended to serve as a public reference of the IPs we egress out of for security scanning as part of the Security Insights service.
Screenshots (optional)
N/A
Documentation checklist
N/A