Feature/update cronjob name #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for WAFRuleIDs (string) and EdgeResponseCompressionRatio (float)
added explicit schema
added logic to read schema from remote JSON file
update schema with additional fields
merge remote-schema
Updated cloud functions storage bucket variable
According to [docs](https://cloud.google.com/functions/docs/migrating/nodejs-runtimes) and warning emails > The Node.js 8 runtime will be deprecated on 2020-06-05 At moment I'm connecting our cloudflare to gcp, and decided to set node to 10 can confirm that everything working
upgrade to node 10
add gcp project id module
* Added Spectrum schema and bash $SCHEMA variable. * type fix for Spectrum schema * add $SCHEMA to automatic install * fix README.md * fix capitalization * Update cloudshell.md Co-authored-by: Frank Taylor <[email protected]>
Resolves cloudflare#48
`logpush-to-bigquery` is now compatible with Cloudflare Logstream! * log files are now batched and inserted into BigQuery on a cron * HTTP / default schema was updated
Author
|
@shagamemnon |
Contributor
|
Thanks @Anticmos. Can you please create a default string value for the # deploy.sh
CRON_JOB_NAME='cf_logs_cron' |
Author
Author
|
@shagamemnon Any updates on this? |
Author
z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As I was making use of this project I ran into a case where if I ran the deploy twice it would not always overwrite the previous CRON job and I also did not have enough control over the name of the cron job for subsequent runs.
This can cause confusion as GCP will just spit out:
ERROR: (gcloud.scheduler.jobs.create.pubsub) ALREADY_EXISTS: Job .../jobs/cf_logs_cron already exists.Please take a look at the addition of a new variable!
Looking forward to feedback.
Thanks!