-
Notifications
You must be signed in to change notification settings - Fork 51
corrected data types #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…on for WAFRuleIDs (string) and EdgeResponseCompressionRatio (float)
added explicit schema
added logic to read schema from remote JSON file
update schema with additional fields
merge remote-schema
Updated cloud functions storage bucket variable
According to [docs](https://cloud.google.com/functions/docs/migrating/nodejs-runtimes) and warning emails > The Node.js 8 runtime will be deprecated on 2020-06-05 At moment I'm connecting our cloudflare to gcp, and decided to set node to 10 can confirm that everything working
upgrade to node 10
add gcp project id module
* Added Spectrum schema and bash $SCHEMA variable. * type fix for Spectrum schema * add $SCHEMA to automatic install * fix README.md * fix capitalization * Update cloudshell.md Co-authored-by: Frank Taylor <[email protected]>
Resolves cloudflare#48
|
Hey @thecodeassassin - thanks for putting this in :) The default timestamp format for Logpush is actually RFC3339 (e.g. ... which is of type It looks like you are using one of the Unix time options instead? Assuming I am reading this correctly, I'm afraid we'll need to find a different solution for your use case. |
|
@shagamemnon thank you for the quick response. We created the logpush job via terraform: for_each = {
for dataset in local.datasets : dataset.id => dataset
}
zone_id = data.cloudflare_zones.zone_id_domain[each.value.domain].zones[0].id
enabled = true
name = replace("${each.value.domain}-${each.value.id}", "/([\\.-_])+/", "-")
destination_conf = "gs://${google_storage_bucket.logs[each.key].name}"
ownership_challenge = data.http.ownership_file[each.key].body
dataset = each.value.dataset
logpull_options = each.value.logpull_options
}Also, on the docs it says int or string. https://developers.cloudflare.com/logs/log-fields Maybe it's only RFC3339 when you create it via the UI? |

The reason for this PR is to correct the data types used in the schemas.
If you don't use the correct data types the following errors occur:
{"reason":"invalidQuery","location":"query","message":"Cannot return an invalid timestamp value of -8505438273863876608 microseconds relative to the Unix epoch. The range of valid timestamp values is [0001-01-1 00:00:00, 9999-12-31 23:59:59.999999]; error in writing field EdgeEndTimestamp"}This PR fixes the incorrect data types