Skip to content

fix(sync): pull every path by default - #17

Closed
mattzcarey wants to merge 1 commit into
mainfrom
fix/sync-all-paths-default
Closed

fix(sync): pull every path by default#17
mattzcarey wants to merge 1 commit into
mainfrom
fix/sync-all-paths-default

Conversation

@mattzcarey

@mattzcarey mattzcarey commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Workspace currently drops every node_modules path from normal backend pulls. The filtering default lives in the remote wsd server, so changing only a new host's local constant would not fix existing released container images.

This makes full synchronization explicit at the pull driver: pullOnce() sends ignore: [], overriding historical wsd defaults and including every path. The protocol's server default is also empty for new peers. Lower-level callers can still configure ServerOptions.ignore or call fetchChanges({ ignore }) directly when they intentionally want filtering.

The regression test records the request sent by pullOnce(), verifies its empty ignore list, and verifies both a normal file and a file under node_modules arrive with their contents. The Durable Object filesystem, RPC, Workspace, and repository-wide typecheck suites pass locally.

Agent-think will consume this pull request's preview package and use one complete synchronized VFS across model file tools and both bash backends.

@pkg-pr-new

pkg-pr-new Bot commented Jul 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/workspace/@cloudflare/workspace@17

commit: da8cd87

@mattzcarey

Copy link
Copy Markdown
Contributor Author

Closing because agent-think does not need to change Workspace's historical node_modules pull behavior right now. This default is primarily relevant to Aron's Hackspace use case and can be revisited there when needed.

@mattzcarey mattzcarey closed this Jul 8, 2026
@mattzcarey
mattzcarey deleted the fix/sync-all-paths-default branch July 8, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant