fix(sync): pull every path by default - #17
Closed
mattzcarey wants to merge 1 commit into
Closed
Conversation
commit: |
mattzcarey
force-pushed
the
fix/sync-all-paths-default
branch
from
July 8, 2026 12:21
0f95e60 to
da8cd87
Compare
Contributor
Author
|
Closing because agent-think does not need to change Workspace's historical node_modules pull behavior right now. This default is primarily relevant to Aron's Hackspace use case and can be revisited there when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace currently drops every
node_modulespath from normal backend pulls. The filtering default lives in the remotewsdserver, so changing only a new host's local constant would not fix existing released container images.This makes full synchronization explicit at the pull driver:
pullOnce()sendsignore: [], overriding historicalwsddefaults and including every path. The protocol's server default is also empty for new peers. Lower-level callers can still configureServerOptions.ignoreor callfetchChanges({ ignore })directly when they intentionally want filtering.The regression test records the request sent by
pullOnce(), verifies its empty ignore list, and verifies both a normal file and a file undernode_modulesarrive with their contents. The Durable Object filesystem, RPC, Workspace, and repository-wide typecheck suites pass locally.Agent-think will consume this pull request's preview package and use one complete synchronized VFS across model file tools and both bash backends.