Add unix domain socket for telemetry server - #128
Merged
Conversation
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
August 13, 2025 09:40
8c9c1c3 to
bfd5bcb
Compare
nox
approved these changes
Aug 13, 2025
nox
left a comment
nox
left a comment
Contributor
There was a problem hiding this comment.
The changes seem reasonable to me but note that this includes breaking changes in public API so that requires a major foundations release.
zakcutner
reviewed
Aug 13, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
4 times, most recently
from
August 15, 2025 16:35
f9f3203 to
690a22f
Compare
zakcutner
reviewed
Aug 15, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
5 times, most recently
from
August 18, 2025 10:05
bc1350b to
abdb38b
Compare
zakcutner
approved these changes
Aug 18, 2025
nox
suggested changes
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
August 19, 2025 15:16
abdb38b to
161ea12
Compare
nox
suggested changes
Aug 20, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
2 times, most recently
from
August 20, 2025 13:16
4f53c41 to
4b14aab
Compare
nox
approved these changes
Aug 20, 2025
Contributor
|
You need to rebase on top of #130 to fix the clippy issues. |
nox
force-pushed
the
unix-domain-sockets
branch
from
August 22, 2025 09:48
4b14aab to
52946a7
Compare
Contributor
|
I rebased it. |
nox
force-pushed
the
unix-domain-sockets
branch
3 times, most recently
from
August 22, 2025 10:13
d0b178f to
376481b
Compare
marmeladema
reviewed
Aug 22, 2025
nox
force-pushed
the
unix-domain-sockets
branch
2 times, most recently
from
August 22, 2025 16:35
f432024 to
fe0456b
Compare
gpgabriel
force-pushed
the
unix-domain-sockets
branch
2 times, most recently
from
August 26, 2025 14:04
245e44c to
a9629f5
Compare
An old socket path will be removed if it exists.
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
August 27, 2025 08:36
a9629f5 to
5f26368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.